fix(amazonq): move workspace lsp messages off blocking thread calls #5816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we are inappropriately freezing EDT while passing workspace context to the LSP
Qodana Community for JVM3 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
Fixed
Show fixed
Hide fixed
manodnyab
approved these changes
Jun 17, 2025
| holder.languageServer | ||
| } | ||
| } catch (_: Exception) { | ||
| LOG.debug { "LSP not running" } |
There was a problem hiding this comment.
nit: should this be an info with exception message?
| chatManager.getAllTabIds().forEach { tabId -> | ||
| AmazonQLspService.executeIfRunning(project) { server -> | ||
| rawEndpoint.notify(CHAT_TAB_REMOVE, mapOf("tabId" to tabId)) | ||
| currentThreadCoroutineScope().launch { |
Check warning
Code scanning / QDJVMC
Unstable API Usage Warning
| } | ||
| AmazonQLspService.didChangeConfiguration(project) | ||
|
|
||
| currentThreadCoroutineScope().launch { |
Check warning
Code scanning / QDJVMC
Unstable API Usage Warning
| } | ||
| } | ||
|
|
||
| fun<T> syncExecuteIfRunning(runnable: suspend AmazonQLspService.(AmazonQLanguageServer) -> T): T? = |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we are inappropriately freezing EDT while passing workspace context to the LSP
#5811
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.